Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use reportValidity instead of checkValidity in validateElement #3215

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: use reportValidity instead of checkValidity in validateElement #3215

wants to merge 1 commit into from

Conversation

xforman2
Copy link

@xforman2 xforman2 commented Mar 2, 2025

Description

Replaced checkValidity with reportValidity as described here #2372 (comment)

Corresponding issue:
#2372

Testing

Tested manually in the scratch demo

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Mar 3, 2025
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Telroshan Telroshan Telroshan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xforman2 @Telroshan