Fix event not being available in hx-vals/hx-vars when hx-trigger has delay #3196
+49
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
hx-vals
(andhx-vars
) you can referenceevent
as shown in the docs forhx-vals
.However when a delay modifier is used in
hx-trigger
this stops being true, since it's actually a reference to window.event, rather than an argument being passed. This is surprising and also its documentation says:Corresponding issue : #1189
Testing
New tests added for
hx-vals
(I didn't copy them forhx-vars
, but I fixed it for parity)Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded