Fix target value in htmx:targetError when inheritance has been used #3178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
hx-target
is inherited, currently the value ofevent.detail.target
forhtmx:targetError
is null.This value should instead be the value that htmx was using to try to resolve the target.
Testing
Added a test for the event when inheritance is not being used, since that seemed to not exist yet.
Then added a test which uses an inherited value for
hx-target
.(I also manually tested that the event doesn't fire when the inherited target does exist.)
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded