chore(abci): Pass the context parameter #2576
Merged
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotes
commented
Mar 6, 2025
| @@ -174,7 +174,7 @@ func (s *Service) Start( | |||
| return err | |||
| } | |||
|
|
|||
| s.ctx = ctx | |||
| s.ResetAppCtx(ctx) | |||
There was a problem hiding this comment.
Also just a nit. Might as well use the setter function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
- Coverage 58.14% 57.94% -0.21%
==========================================
Files 335 338 +3
Lines 15036 15122 +86
Branches 0 20 +20
==========================================
+ Hits 8743 8762 +19
- Misses 5632 5698 +66
- Partials 661 662 +1
🚀 New features to boost your workflow:
|
shotes
commented
Mar 6, 2025
| @@ -46,7 +46,7 @@ func (s *Service) InitChain( | |||
| return &cmtabci.InitChainResponse{}, s.ctx.Err() | |||
| } | |||
| //nolint:contextcheck // see s.ctx comment for more details | |||
| return s.initChain(req) // internally this uses s.ctx | |||
| return s.initChain(s.ctx, req) | |||
There was a problem hiding this comment.
With this PR, I could easily interchange this s.ctx with the ctx that is provided in the function parameters.
|
Also note that on |
abi87
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the beacond App's
s.ctxcontext field as a parameter to the ABCI functions imitates the functionality of using thectxfrom CometBFT. This makes it so that the arguments in each ABCI function call are easily swappable betweens.ctxandctx, should CometBFT ever fully implement theirctx.