Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): Fix error type and clean up interface definition #2515

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

rezbera
Copy link
Contributor

@rezbera rezbera commented Feb 15, 2025

Error message for Blobs decoding was incorrectly using messages meant for beacon blocks

@rezbera rezbera requested a review from a team as a code owner February 15, 2025 07:53
@rezbera rezbera changed the title chore(types): Fix error and clean up interface definition chore(types): Fix error type and clean up interface definition Feb 15, 2025
@rezbera rezbera requested a review from a team February 15, 2025 07:54
@rezbera rezbera enabled auto-merge (squash) February 15, 2025 07:54
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.31%. Comparing base (70cb888) to head (c37e5fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
consensus/cometbft/service/encoding/encoding.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2515   +/-   ##
=======================================
  Coverage   32.31%   32.31%           
=======================================
  Files         350      350           
  Lines       15670    15670           
  Branches       20       20           
=======================================
  Hits         5063     5063           
  Misses      10244    10244           
  Partials      363      363           
Files with missing lines Coverage Δ
consensus/cometbft/service/encoding/encoding.go 0.00% <0.00%> (ø)

@rezbera rezbera merged commit 2dc5822 into main Feb 15, 2025
19 checks passed
@rezbera rezbera deleted the fix-error-returned branch February 15, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants