fix(blobs): cleanup logging and node-api handling of blobs #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 32.31% 32.30% -0.01%
==========================================
Files 350 350
Lines 15672 15674 +2
Branches 20 20
==========================================
Hits 5064 5064
- Misses 10245 10247 +2
Partials 363 363
|
calbera
commented
Feb 6, 2025
Comment on lines
+40
to
+43
| // If the requested slot is 0 (head, finalized, justified), use the current slot. | ||
| if slot == 0 { | ||
| slot = math.Slot(currentSlot) | ||
| } |
There was a problem hiding this comment.
this is the main fix of this PR. we resolve "head", "finalized" and "justified" blockIDs to slot 0, which hits the node query context for the latest height.
shotes
approved these changes
Feb 7, 2025
nidhi-singh02
had a problem deploying
to
test-e2e
GitHub Actions
Error
calbera
changed the title
shotes
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
nits on using getter for slot. Otherwise LGTM.
Not a big deal for the getter nits. I've been wanting to clean up data handling and exported values around the codebase as a whole for awhile now. For now, I think we should be diligently using getters where expected.
Co-authored-by: Shota Ehrlich <[email protected]> Signed-off-by: Cal Bera <[email protected]>
Co-authored-by: Shota Ehrlich <[email protected]> Signed-off-by: Cal Bera <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple cleanup for blobs endpoint in beacon api