fix(engine api): [1/3] error on engine API errors #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
+ Coverage 32.24% 32.35% +0.10%
==========================================
Files 350 350
Lines 15653 15595 -58
Branches 20 20
==========================================
- Hits 5047 5045 -2
+ Misses 10243 10187 -56
Partials 363 363
|
abi87
reviewed
Feb 6, 2025
Comment on lines
67
to
70
| s.logger.Error( | ||
| "failed to send forkchoice update without attributes", | ||
| "error", err, | ||
| ) |
There was a problem hiding this comment.
replaced logs with more expressive errors
shotes
changed the title
shotes
changed the title
abi87
reviewed
Feb 6, 2025
| @@ -96,13 +96,13 @@ func (ee *Engine) NotifyForkchoiceUpdate( | |||
| // We do not bubble the error up, since we want to handle it | |||
| // in the same way as the other cases. | |||
| ee.metrics.markForkchoiceUpdateSyncing(req.State, err) | |||
| return payloadID, nil, nil | |||
There was a problem hiding this comment.
I don't see why we should return anything other than nil payload and latestValidaHash when it errs
abi87
reviewed
Feb 6, 2025
| @@ -181,8 +183,7 @@ func (s *Service) executeStateTransition( | |||
| WithVerifyPayload(true). | |||
| WithVerifyRandao(false). | |||
| WithVerifyResult(false). | |||
| WithMeterGas(true). | |||
| WithOptimisticEngine(true) | |||
There was a problem hiding this comment.
Dropped WithOptimisticEngine since we don't silence any error anymore
rezbera
reviewed
Feb 7, 2025
| ), | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed sending forkchoice update without attributes: %w", err) |
There was a problem hiding this comment.
can we decorate the error with information about the hashes as well, could be useful
rezbera
reviewed
Feb 7, 2025
| @@ -79,7 +80,7 @@ func (pb *PayloadBuilder) RequestPayloadAsync( | |||
| }, | |||
| ) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("RequestPayloadAsync failed sending forkchoice update: %w", err) | |||
There was a problem hiding this comment.
not for this pr but we should consider renaming RequestPayloadAsync
rezbera
approved these changes
Feb 7, 2025
abi87
approved these changes
Feb 7, 2025
calbera
force-pushed
the
deposit-sync-enforce-error
branch
from
30e1cb9 to
12cf8d9
Compare
calbera
approved these changes
Feb 7, 2025
|
Noting behavior of full node:
|
calbera
pushed a commit
that referenced
this pull request
Feb 12, 2025
shotes
added a commit
that referenced
this pull request
Feb 12, 2025
)" (#…" This reverts commit 7d43017.
nidhi-singh02
pushed a commit
that referenced
this pull request
Feb 17, 2025
Co-authored-by: aBear <[email protected]> Co-authored-by: Cal Bera <[email protected]>
nidhi-singh02
pushed a commit
that referenced
this pull request
Feb 17, 2025
abi87
added a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: aBear <[email protected]> Co-authored-by: Cal Bera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FinalizeBlock'sengine_forkchoiceUpdatedcall.engine_newPayloadandengine_forkchoiceUpdatedfailures. Thereforetransaction.Contextand the engine.With both of these, we ensure that the CL will fail when it goes out of sync with the EL.
In future PRs, we should attempt retries on these engine API calls to allow for easier recovery.