fix(state-transition): Correctly enforce deposits length to avoid panics #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
===========================================
+ Coverage 21.17% 31.21% +10.03%
===========================================
Files 3 346 +343
Lines 85 15426 +15341
Branches 20 20
===========================================
+ Hits 18 4815 +4797
- Misses 66 10273 +10207
- Partials 1 338 +337
|
calbera
commented
Jan 18, 2025
| @@ -107,3 +105,76 @@ func TestInvalidDeposits(t *testing.T) { | |||
| require.Error(t, err) | |||
| require.ErrorContains(t, err, "deposit mismatched") | |||
| } | |||
|
|
|||
| func TestInvalidDepositsCount(t *testing.T) { | |||
There was a problem hiding this comment.
previously this test would panic
abi87
approved these changes
Jan 18, 2025
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
…ics (#2369) Co-authored-by: aBear <[email protected]>
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
…ics (#2369) Co-authored-by: aBear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have a length check before. If a verifying node did not have up-to-date the latest deposits that are included in block, we would panic in their process proposal (OR finalize block). This PR fixes by erroring to REJECT the proposal in this case.