fix(blobs): Validate sidecar KzgCommitments and disallow sidecar omission
#2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 30.85% 30.77% -0.08%
==========================================
Files 333 333
Lines 15237 15283 +46
Branches 20 20
==========================================
+ Hits 4702 4704 +2
- Misses 10210 10254 +44
Partials 325 325
|
shotes
force-pushed
the
blob-duplicates-check
branch
from
6831d90 to
f040e37
Compare
shotes
changed the title
KzgCommitments and disallow sidecar omission
calbera
reviewed
Dec 20, 2024
| // VerifyIncomingBlock). | ||
| // Make sure we have the right number of BlobSidecars | ||
| numCommitments := len(blk.GetBody().GetBlobKzgCommitments()) | ||
| if numCommitments != sidecars.Len() { |
There was a problem hiding this comment.
although we already check before calling .Len() if sidecars.IsNil() I think we should prevent any sidecars function from ever panicking on its own
There was a problem hiding this comment.
i.e. here Len, GetSidecars, Get should all check .IsNil before dereferencing the pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things: