feat(staking): Log Handler #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdevbear
reviewed
Feb 17, 2024
beacon/staking/deposit.go
Outdated
| withdrawalCredentials, | ||
| ) | ||
| // Cache the deposit to be pushed to the queue later in batch. | ||
| err = beaconState.CacheDeposit(deposit) |
There was a problem hiding this comment.
We should put the cache on the service tbh. the State() should be really simple CRUD operations
itsdevbear
reviewed
Feb 17, 2024
itsdevbear
approved these changes
Feb 17, 2024
| return nil | ||
| } | ||
|
|
||
| // PersistDeposits commits the cached deposits to the queue | ||
| // and processes the queued deposits. | ||
| func (s *BeaconStore) PersistDeposits(n uint64) ([]*Deposit, error) { | ||
| func (s *BeaconStore) PersistDeposits(depositCache []*Deposit, n uint64) ([]*Deposit, error) { |
There was a problem hiding this comment.
I think we should move the check from within the store to the staking service, BeaconStore / State is supposed to be dumb CRUD logic.
|
@itsdevbear Is it branch good to merge? I added |
itsdevbear
reviewed
Feb 19, 2024
abi87
pushed a commit
that referenced
this pull request
Feb 13, 2025
…load (#160) * Update state_processor_payload.go * only pass consensus time rather than full transitionctx * rename txctx
abi87
pushed a commit
that referenced
this pull request
Feb 13, 2025
…load (#160) * Update state_processor_payload.go * only pass consensus time rather than full transitionctx * rename txctx
abi87
pushed a commit
that referenced
this pull request
Feb 13, 2025
…load (#160) * Update state_processor_payload.go * only pass consensus time rather than full transitionctx * rename txctx
abi87
pushed a commit
that referenced
this pull request
Feb 14, 2025
…load (#160) * Update state_processor_payload.go * only pass consensus time rather than full transitionctx * rename txctx
abi87
pushed a commit
that referenced
this pull request
Feb 14, 2025
…load (#160) * Update state_processor_payload.go * only pass consensus time rather than full transitionctx * rename txctx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
New Features
ProcessLogsto theBuilderServiceinterface for processing logs.logProcessorfield for processing logs and astfield for staking service in theServicestruct.LogProcessorandStakingServiceof theService.ProcessLogsin theServicestruct for log processing and deposit persistence.Refactor
ProcessLogsmethod to handle errors during log processing and persist deposits.Chores