Support Flow "declare class" fully: type parameters, "extends", "implements" #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
added a commit
to gnprice/ast-types
that referenced
this pull request
Apr 27, 2022
This is already produced by flow-parser to support Flow's
`declare class A implements B {}`.
At the moment it's ignored by the Recast printer, but I've sent a PR
to fix that, along with other features of `declare class`:
benjamn/recast#1090
gnprice
added a commit
to gnprice/tsflower
that referenced
this pull request
Apr 27, 2022
This adds fixes for DeclareClass: benjamn/ast-types#746 benjamn/recast#1090
eventualbuddha
force-pushed
the
pr-flow-declareclass
branch
from
f2a0f05 to
7f3e8ba
Compare
…ements". This is basically copied from the "ClassDeclaration" case. There's so much in common between them -- it'd be nice to share most of this logic.
These have so much in common that when they're implemented separately, it's easy (as the breakage fixed in the previous commit demonstrates) for one of them to lag behind in getting a feature the other has.
eventualbuddha
force-pushed
the
pr-flow-declareclass
branch
from
7f3e8ba to
7891bc7
Compare
|
Fixed in v0.21.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add test cases.
The first commit does this by basically copying from the "ClassDeclaration" case.
But there's so much in common between them -- it'd be nice to share most of this logic. Otherwise, as this breakage demonstrates, it's easy for one of them to lag behind in getting a feature the other has. So in the second commit, we unify the handling of "DeclareClass" (used for Flow "declare class …") with "ClassDeclaration" and "ClassExpression", which are already unified with each other.
The "implements" property on "DeclareClass" isn't yet known to ast-types -- I'll send a PR there for that. But it's already emitted by flow-parser, so the round-trip tests already work.