Add output_order keyword for returning the dictionary with the alignment order (rather than input order) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a modified version of clustal-omega (see my other repository)
|
Thank you for this PR! Being able to return results in the alignment order is a nice addition. Apologies for the delay in responding, we have been quite backlogged on other work and this escaped our notice. We will do a thorough review as soon as we can. |
|
Hello! Thanks for taking notice, just wanted to gently poke about this. I know things are stressful so no worries, but if this can get merged it'll help my own project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a keyword for returning the dictionary with the alignment order so that it runs comparably to the Clustal Omega webserver or binary. Only works if there are more than two sequences... ClustalO doesn't calculate the tree_order otherwise. But I got it to not crash at least.
Also only works on Python versions >3.6, as that was when dictionaries became ordered (otherwise, the order will just be totally random).
I created an issue for records purposes here: #7