Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base docker image to debian slim #107

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Change base docker image to debian slim #107

merged 1 commit into from
Jan 5, 2018

Conversation

smacker
Copy link
Collaborator

@smacker smacker commented Jan 5, 2018 •
edited
Loading

binary compiled with cgo don't work on alpine

we need cgo because of client-go and we need client-go because we need query filtering:
it was introduced here #74

dpordomingo
dpordomingo approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@smacker smacker merged commit 6e77f41 into bblfsh:master Jan 5, 2018
@smacker smacker mentioned this pull request Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

@bzz bzz bzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smacker @dpordomingo @bzz