[8.2.0] Fix reduced classpath logic on Windows #25508
Open
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reduced classpath computation for Java compilation actions with deps on jdeps files that were produced on Windows always resulted in an empty reduced classpath since both JavaBuilder and Turbine emitted backslash-separated paths into the jdeps proto, but Bazel matches them against slash-separated paths. This is fixed by changing JavaBuilder to always emit slash-separated paths and updating Turbine to a version that does so (google/turbine#363). Work towards bazelbuild#24876, which will also provide an integration test. Closes bazelbuild#25435. PiperOrigin-RevId: 733284003 Change-Id: Ide29965d4676fdd2bda4baaced50f984ee7284f0 (cherry picked from commit 752f72b)
github-actions
bot
added
team-Rules-Java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reduced classpath computation for Java compilation actions with deps on jdeps files that were produced on Windows always resulted in an empty reduced classpath since both JavaBuilder and Turbine emitted backslash-separated paths into the jdeps proto, but Bazel matches them against slash-separated paths.
This is fixed by changing JavaBuilder to always emit slash-separated paths and updating Turbine to a version that does so (google/turbine#363).
Work towards #24876, which will also provide an integration test.
Closes #25435.
PiperOrigin-RevId: 733284003
Change-Id: Ide29965d4676fdd2bda4baaced50f984ee7284f0
(cherry picked from commit 752f72b)
Fixes #25446