[8.2.0] Fix Unicode encoding issues in Bazel's use of Starlark #25451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel internally uses `String` as a container for raw bytes assumed to be UTF-8, which differs from ordinary usage of `String` as a container for UTF-16 characters. This requires special implementations of certain Starlark functions that care about the notion of a "character":
* `{l,r,}strip` must not strip non-ASCII whitespace as it may be part of a UTF-8-encoded non-whitespace character.
* `json.decode` has to emit UTF-8 bytes rather than UTF-16 characters.
To avoid affecting other users of the Starlark interpreter, a new `StarlarkSemantics.INTERNAL_BAZEL_ONLY_UTF_8_BYTE_STRINGS` setting, defaulting to false but overridden to true for Bazel, determines which of the two behaviors to adopt.
Compatibility is verified by running all script-based tests under both values of the setting.
Closes bazelbuild#24417.
PiperOrigin-RevId: 733329982
Change-Id: I3e1605be28a844ab52a3239a2f753a29d4eb217a
bazel-io
added
team-Starlark-Integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel internally uses
Stringas a container for raw bytes assumed to be UTF-8, which differs from ordinary usage ofStringas a container for UTF-16 characters. This requires special implementations of certain Starlark functions that care about the notion of a "character":{l,r,}stripmust not strip non-ASCII whitespace as it may be part of a UTF-8-encoded non-whitespace character.json.decodehas to emit UTF-8 bytes rather than UTF-16 characters.To avoid affecting other users of the Starlark interpreter, a new
StarlarkSemantics.INTERNAL_BAZEL_ONLY_UTF_8_BYTE_STRINGSsetting, defaulting to false but overridden to true for Bazel, determines which of the two behaviors to adopt.Compatibility is verified by running all script-based tests under both values of the setting.
Closes #24417.
PiperOrigin-RevId: 733329982
Change-Id: I3e1605be28a844ab52a3239a2f753a29d4eb217a
Commit fcd3d19