Always run Turbine native image with a UTF-8 code page on Windows #25444
+200
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
fmeum
changed the title
fmeum
changed the title
|
@bazel-io fork 8.2.0 |
meteorcloudy
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
I'm fine with the custom tool to add/update windows manifest file. Just in case we need more complex feature in future, we could switch to use mt.exe from the windows SDK, which can be fetched by updating https://github.com/bazelbuild/bazel/blob/master/src/main/res/winsdk_configure.bzl.
meteorcloudy
added
awaiting-PR-merge
|
@hvadehra Please take a final look |
hvadehra
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building Turbine native images with a UTF-8 code page and need to match the runtime code page for UTF-8 paths to be handled properly. This change splits the existing tool for patching the app manifest of the embedded JDK into separate tools for reading and writing app manifests. The write tool is then used to add a manifest to the turbine binary.