Fix typo in example on testing.md.

[cfredric]

The example says that foo should correspond to provider_contents earlier in the text.

[gregestren]

I don't have domain expertise on this, but note 5a74742 switched this in the other direction. I'll see if I can CC the original contributor for input.

[gregestren]

@sfreilich - what do you think?

[cfredric]

That commit looks like a big one focused on formatting; I'd be surprised if the switch of provider_contents to provider_contents_test in that commit was intentional.

[gregestren]

So reviewing some more, it looks like the foo part is wrong, not the actual name.

In other words, the current text is:

the label of the target of this rule type should be foo (provider_contents_test)

If you look at the code it's referencing:

# Testing rule.
    provider_contents_test(name = "provider_contents_test",
  ...

That's an example of a foo_test name (provider_contents_test).

What do you think?

[gregestren]

When you said "earlier in the text", which text specifically did you mean?

[cfredric]

I'm referring to the following text:

For consistency, follow the recommended naming convention: Let `foo` stand for
the part of the test name that describes what the test is checking
(`provider_contents` in the above example).

starting on line 160.

[gregestren]

Thanks. So my reading of the whole text is:

• foo -> provider_contents
• macro that generates the test: def _test_foo -> def _test_provider_contents():
• test rule type: foo_test -> provider_contents_test = analysistest.make(_provider_contents_test_impl)
• label of the target: foo_test -> provider_contents_test(name = "provider_contents_test",
• implementation function: _foo_test_impl -> def _provider_contents_test_impl(ctx):
• label of targets under test: foo_* -> target_under_test = ":provider_contents_subject")

So the part of the text reading the label of the target of this rule type should be foo is incorrect: there's no label in the example code matching foo.

[cfredric]

Hmm, you're probably right; it wouldn't make much sense to have a target named foo whose rule type is foo_test. In that case, I think the bullet should be changed to:

* the label of the target of this rule type should be `foo_test` (`provider_contents_test`)'

WDYT?

[gregestren]

Yes, I think that'd work!