Add support for aarch64 on user-provided URLs #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brt
reviewed
Sep 14, 2021
|
@brian-brt I'm happy to drop this for something better. This was basically a hack we did in order to unblock and I opened the PR for visibility. |
|
Thanks for the PR. I don't think I have permissions to update your PR branch, so I will merge this as commit independent of the PR. |
|
Merged with 85022a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can only provide URLs for
linuxanddarwin, regardless of the architecture. We recently started to support aarch64 and there was no way to provide a custom llvm toolchain for it.This needs some polishing but I'm putting it up for review to gather initial feedback. Also in case something like this is already on the works.
The code was written by @ryan-johnson-databricks