Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos and Improve Readability in Deployment Scripts and Logs #281

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SITADRITA1
Copy link

Fixed a typo in the script name

Before: etherscan-verifiy-l2-bedrock-implementations:
After: etherscan-verify-l2-bedrock-implementations:
Reason: The word "verifiy" was misspelled. Correcting it to "verify" ensures proper command execution.
Corrected a typo in a logging statement

Before: console.log("Incrememnting by 1 to account for planned \Update tx");
After: console.log("Incrementing by 1 to account for planned \Update tx");
Reason: The word "Incrememnting" was misspelled. Fixing this improves readability and ensures clarity in logs.
Fixed a typo in a comment regarding L2OutputOracle deployment

Before: // Deploy L2OutputOracle new implementation wiht the new submission interval
After: // Deploy L2OutputOracle new implementation with the new submission interval
Reason: The word "wiht" was misspelled. Correcting it to "with" ensures the comment is clear.
Fixed a typo in a facilitator command description

Before: # Commands for faciliators to run to test the nested safe
After: # Commands for facilitators to run to test the nested safe
Reason: The word "faciliators" was misspelled. The correct spelling is "facilitators."

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@SITADRITA1
Copy link
Author

If there are any mistakes, please let me know, and I will fix them. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants