Add support for Node 18 #3987
Merged
Add support for Node 18 #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfunckt
force-pushed
the
support-node-18
branch
3 times, most recently
from
e798ad3 to
9f0b00c
Compare
The Electron version we’re currently using is on Node 14 but this is a step forward to upgrading to a newer Electron and Node version. Updates etcher-sdk and switches the redundant aws4-axios dependency to just axios. Also changed bundler to stop trying to bundle wasm files — they must be included inline with JS code as data — and removed some now redundant code. The crucial changes that enable support are: 1. The update to etcher-sdk@8 where some dependency fixes and updates took place 2. The downgrade and pinning of "electron-rebuild" to v3.2.3 until we’re able to update to Electron >= 14.2. The patch we need to avoid is electron/rebuild#907. Also see: nodejs/node-gyp#2673 and electron/rebuild#913 3. A rule in webpack.config to ignore `aws-crt` which is a dependency of (ultimately) `aws4-axios` which is used by etcher-sdk and does a runtime check to its availability. We’re not currently using the “assume role” functionality (AFAIU) of aws4-axios and we don’t care that it’s not found, so force webpack to ignore the import. See aws/aws-sdk-js-v3#3025 Change-type: minor
dfunckt
force-pushed
the
support-node-18
branch
from
9f0b00c to
887ec42
Compare
|
I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Electron version we’re currently using is on Node 14 but this is a step forward to upgrading to a newer Electron and Node version.
Updates etcher-sdk and switches the redundant aws4-axios dependency to just axios.
Also changed bundler to stop trying to bundle wasm files — they must be included inline with JS code as data — and removed some now redundant code.
The crucial changes that enable support are:
aws-crtwhich is a dependency of (ultimately)aws4-axioswhich is used by etcher-sdk and does a runtime check to its availability. We’re not currently using the “assume role” functionality (AFAIU) of aws4-axios and we don’t care that it’s not found, so force webpack to ignore the import. See Module not found: Error: Can't resolve 'aws-crt' aws/aws-sdk-js-v3#3025Change-type: minor