Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back restricted Stream.AddStream functionality #1331

Merged
merged 8 commits into from
Jan 19, 2025

Conversation

OpenJeDi
Copy link
Contributor

This pull requests adds back Stream.AddStream and Stream.AddStream and Stream.RemoveStream after they were removed due to CVE-2023-36177.

The Stream.StartStream is restricted to be more secure:

  • we don't allow to start process streams
  • we don't allow the controlscript parameter

It is actually a property of the streamUri URI instead of a separate parameter
@badaix badaix merged commit 9254be1 into badaix:develop Jan 19, 2025
56 of 60 checks passed
@badaix
Copy link
Owner

badaix commented Jan 19, 2025

Thanks!

@OpenJeDi OpenJeDi deleted the rpc-add-restricted-addstream branch January 19, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants