Introduce more Swift components #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 20, 2015 12:06
Include tests that are identical to previous tests, but test the corresponding Swift, not Objective-C, component. This is to ensure the new Swift components behave exactly the same as their Objective-C counterparts.
|
(No files were inherited from/harmed in the making of this pull request.) |
|
This is amazing. I’ll take a better look tonight. 👀 Thanks for this! |
|
Alright, I’m going to merge this. We can make tweaks as needed later. Love that you removed subclassing, thanks!! 😄 |
ayanonagon
added a commit
that referenced
this pull request
Feb 21, 2015
Introduce more Swift components
|
🔧 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits for a two-pass approach: first, add the Swift components, and their tests. Then, remove the Objective-C files we no longer need 🔪. (The public-facing APIs between the two versions are identical.)
Since we're not pure Swift yet, we can't optimize the new Swift classes as much as I'd like since they still need to be visible to Objective-C. I'll go through and comment where we can simplify somethings—our basic analyzers can be immutable value types when it's all said and done. 🙌