Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that --port takes full listen address #153

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

luisgerhorst
Copy link
Contributor

Issue #, if available: NA

Description of changes: I considered adding a --listen flag and deprecating --port, however, this would make this simple change too complicated in my opinion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@luisgerhorst
Copy link
Contributor Author

@luisgerhorst
Copy link
Contributor Author

It would be great to have this merged, as we rely on the feature and documenting it like this will ensure that it is not unintentionally removed in a future version.

@rapphil
Copy link
Collaborator

rapphil commented Feb 12, 2025

Thank you!

@rapphil rapphil merged commit 78c3400 into awslabs:master Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants