Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Loop & Socket Type Multi-Support #692

Merged
merged 79 commits into from
Jan 8, 2025
Merged

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Nov 7, 2024

Issue #, if available:

Description of changes:

  • Allow select from different event loop type
  • Allow select from different socket implementation
  • The CI Job was renamed as we introduced new compile options. I will update the required CI once before merge.
    macos -> macos(kqueue)
    macos-debug -> macos-debug (kqueue)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 67.33333% with 49 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (4a4ebae) to head (18b5d82).

Files with missing lines Patch % Lines
source/event_loop.c 44.23% 29 Missing ⚠️
source/socket.c 74.68% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   80.08%   79.69%   -0.40%     
==========================================
  Files          29       30       +1     
  Lines        6001     6117     +116     
==========================================
+ Hits         4806     4875      +69     
- Misses       1195     1242      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiazhvera xiazhvera changed the title Event Loop Type Multi-Support Event Loop Type & Socket Multi-Support Nov 8, 2024
@@ -131,7 +131,8 @@ struct aws_event_loop_vtable s_kqueue_vtable = {
.is_on_callers_thread = s_is_event_thread,
};

struct aws_event_loop *aws_event_loop_new_default_with_options(
#ifdef AWS_ENABLE_KQUEUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, a rephrasing: "why is this source file being compiled if AWS_ENABLE_KQUEUE is not defined at compile time?"

@xiazhvera
Copy link
Contributor Author

The CI Job was renamed as we introduced new compile options. I will update the required CI once before merge.
macos -> macos(-DAWS_USE_APPLE_NETWORK_FRAMEWORK=OFF)
macos-debug -> macos-debug (-DAWS_USE_APPLE_NETWORK_FRAMEWORK=OFF)

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix n ship. Check with Mike to see if he wants to give another look.

@xiazhvera xiazhvera merged commit fdb053b into main Jan 8, 2025
43 checks passed
@xiazhvera xiazhvera deleted the runtime_select_event_loop branch January 8, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants