-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Loop & Socket Type Multi-Support #692
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 80.08% 79.69% -0.40%
==========================================
Files 29 30 +1
Lines 6001 6117 +116
==========================================
+ Hits 4806 4875 +69
- Misses 1195 1242 +47 ☔ View full report in Codecov by Sentry. |
@@ -131,7 +131,8 @@ struct aws_event_loop_vtable s_kqueue_vtable = { | |||
.is_on_callers_thread = s_is_event_thread, | |||
}; | |||
|
|||
struct aws_event_loop *aws_event_loop_new_default_with_options( | |||
#ifdef AWS_ENABLE_KQUEUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, a rephrasing: "why is this source file being compiled if AWS_ENABLE_KQUEUE is not defined at compile time?"
The CI Job was renamed as we introduced new compile options. I will update the required CI once before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix n ship. Check with Mike to see if he wants to give another look.
Issue #, if available:
Description of changes:
macos -> macos(kqueue)
macos-debug -> macos-debug (kqueue)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.