Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use s2n_cleanup_thread() and path #682

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Use s2n_cleanup_thread() and path #682

merged 11 commits into from
Oct 10, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 10, 2024

See: aws/s2n-tls#4584

follow up for #680

  • Tested on java with insource build here
  • Tested on Python with prebuild-s2n here
  • Also tested the nodejs issue locally, no crash.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.32%. Comparing base (9e1bb08) to head (4a2735c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files          28       28           
  Lines        5992     5992           
=======================================
  Hits         4813     4813           
  Misses       1179     1179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TingDaoK TingDaoK merged commit dc41ddc into main Oct 10, 2024
39 checks passed
@TingDaoK TingDaoK deleted the prebuild-s2n branch October 10, 2024 18:47
graebm added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants