fix(java): missing remarks in builder documentation #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Javadoc entries for setting methods on the generated `Builder` classes did not represent the `remarks` section of the `docs` object, resulting in only partial documentation being available on the builders. This makes sure the `remarks` section gets rendered correctly in all the locations that previously ignored it, and the fix is demonstrated good by virtue of the changes it induced in the regression test improvements. Fixes #1094
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Dec 10, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javadoc entries for setting methods on the generated
Builderclasses did not represent the
remarkssection of thedocsobject,resulting in only partial documentation being available on the builders.
This makes sure the
remarkssection gets rendered correctly in all thelocations that previously ignored it, and the fix is demonstrated good
by virtue of the changes it induced in the regression test improvements.
Fixes #1094
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.