Skip to content

Commit

Permalink
fix(pacmak): missing python artifacts when using relative -o path (#3518
Browse files Browse the repository at this point in the history
)

When the `-o`/`--outdir` option is passed to `jsii-pacmak` with a
relative path, that path was not resolved up-front by the CLI, which
resulted in the Python code-generator not outputting the wheel files in
the expected directory: instead of being consistently treated as
relative to the current working directory, the Python generator
interpreted it relative to it's temporary working directory.

This addresses the issue by resolving relative paths to absolute paths,
using `process.cwd()` as the base directory, before passing the value
down to the business logic.

See aws/aws-cdk#20041



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
  • Loading branch information
RomainMuller authored May 5, 2022
1 parent ca0ee03 commit cc9b561
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 18 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,15 @@
"contributions": [
"maintenance"
]
},
{
"login": "jusdino",
"name": "Justin Frahm",
"avatar_url": "https://avatars.githubusercontent.com/u/11840575?v=4",
"profile": "https://github.com/jusdino",
"contributions": [
"bug"
]
}
],
"repoType": "github",
Expand Down
Loading

0 comments on commit cc9b561

Please sign in to comment.