Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing routingMode parameters for helm configuration #9399

Closed
wants to merge 2 commits into from

Conversation

parlakisik
Copy link
Contributor

Issue #, if available:

*Description of changes:
The routingMode parameter name injecting differently "routing-mode" This cause the wrong cilium configuration deployment.

With 1.15 , cilium also require ipv4NativeRoutingCIDR or ipv6NativeRoutingCIDR parameters if routingMode is set to native

*Testing (if applicable): vsphere deployment

*Documentation added/planned (if applicable): Planning to update native configuration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The routingMode parameter name injecting differently "routing-mode"
This cause the wrong cilium configuration deployment.

With 1.15 , cilium also require ipv4NativeRoutingCIDR or
ipv6NativeRoutingCIDR parameters if routingMode is set to native
@parlakisik parlakisik requested a review from 2ez4szliu March 11, 2025 20:10
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cxbrowne1207 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Hi @parlakisik. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2025
The routingMode parameter name injecting differently "routing-mode"
This cause the wrong cilium configuration deployment.

With 1.15 , cilium also require ipv4NativeRoutingCIDR or
ipv6NativeRoutingCIDR parameters if routingMode is set to native
@parlakisik parlakisik closed this Mar 11, 2025
@parlakisik parlakisik deleted the routemode branch March 11, 2025 23:29
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (da601ea) to head (afb37ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9399      +/-   ##
==========================================
- Coverage   69.46%   69.45%   -0.01%     
==========================================
  Files         672      672              
  Lines       49360    49361       +1     
==========================================
- Hits        34286    34284       -2     
- Misses      13288    13290       +2     
- Partials     1786     1787       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants