Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlink to public.ecr repository #9378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JobRamos
Copy link

@JobRamos JobRamos commented Mar 4, 2025

Enhances the Package Bundles documentation by adding a direct hyperlink to the ECR repository (https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles). Current documentation only references public.ecr.aws/eks-anywhere without a direct link

Adding the ECR repository link will:

  • Improve user experience by providing quick access to the repository
  • Enable users to easily discover and access historical package bundle versions
  • Simplify the process of finding specific tags for packagebundles images

Issue #, if available:

Description of changes: docs/content/en/docs/packages/packagebundles.md | line 25

Testing (if applicable):

Documentation added/planned (if applicable): https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added link reference to the https://anywhere.eks.amazonaws.com/docs/packages/packagebundles/ page on the line 25 to redirect user to public.ecr repository
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrisnegus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Hi @JobRamos. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2025
@abhay-krishna
Copy link
Member

@JobRamos Thanks for your contribution! The hyperlink you've added points to the same documentation page (docs/packages/packagebundles) and not the public ECR repository. I think you intended to link to https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles

@JobRamos
Copy link
Author

JobRamos commented Mar 5, 2025

Hi @abhay-krishna

Correct, that would be the right link.

Also, I think a good improvement would be to add a reference to the ecr repositories on each package bundle page

@abhay-krishna
Copy link
Member

Hi @abhay-krishna

Correct, that would be the right link.

Also, I think a good improvement would be to add a reference to the ecr repositories on each package bundle page

Could you update to the correct link?

Other than the bundles and the images in the package-controller Helm chart, the other images i.e., actual package images are all in private ECR. So even if we add a reference to the repos, customers can't access the console to see images.

@JobRamos
Copy link
Author

JobRamos commented Mar 5, 2025

Just updated the link.

Thanks for clarifying the ECR private repositories concern.

@abhay-krishna
Copy link
Member

/ok-to-test

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (4a63397) to head (182342a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9378   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files         672      672           
  Lines       49357    49357           
=======================================
  Hits        34283    34283           
  Misses      13288    13288           
  Partials     1786     1786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants