-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hyperlink to public.ecr repository #9378
base: main
Are you sure you want to change the base?
Conversation
Added link reference to the https://anywhere.eks.amazonaws.com/docs/packages/packagebundles/ page on the line 25 to redirect user to public.ecr repository
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JobRamos. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JobRamos Thanks for your contribution! The hyperlink you've added points to the same documentation page (docs/packages/packagebundles) and not the public ECR repository. I think you intended to link to https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles |
Correct, that would be the right link. Also, I think a good improvement would be to add a reference to the ecr repositories on each package bundle page |
Could you update to the correct link? Other than the bundles and the images in the package-controller Helm chart, the other images i.e., actual package images are all in private ECR. So even if we add a reference to the repos, customers can't access the console to see images. |
Just updated the link. Thanks for clarifying the ECR private repositories concern. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9378 +/- ##
=======================================
Coverage 69.45% 69.45%
=======================================
Files 672 672
Lines 49357 49357
=======================================
Hits 34283 34283
Misses 13288 13288
Partials 1786 1786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enhances the Package Bundles documentation by adding a direct hyperlink to the ECR repository (https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles). Current documentation only references public.ecr.aws/eks-anywhere without a direct link
Adding the ECR repository link will:
Issue #, if available:
Description of changes: docs/content/en/docs/packages/packagebundles.md | line 25
Testing (if applicable):
Documentation added/planned (if applicable): https://gallery.ecr.aws/eks-anywhere/eks-anywhere-packages-bundles
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.