Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog for Curated Packages Release #9368

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jhaanvi5
Copy link
Member

@jhaanvi5 jhaanvi5 commented Mar 3, 2025

Description of changes:

  • Update Changelog for Curated Packages Release

Testing (if applicable):

make container-build
make container-serve

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhaanvi5. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (383908d) to head (862c39a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9368      +/-   ##
==========================================
- Coverage   69.45%   69.45%   -0.01%     
==========================================
  Files         672      672              
  Lines       49357    49357              
==========================================
- Hits        34283    34280       -3     
- Misses      13288    13290       +2     
- Partials     1786     1787       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


- Harbor `2.11.1` to `2.12.1`
- ADOT `0.41.1` to `0.42.0`
- The `logging` exporter is now [deprecated](https://github.com/open-telemetry/opentelemetry-collector/pull/11037), users should update the config to the `debug` exporter instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reference on how they should perform this change in upstream docs or a specific comment?

Suggested change
- The `logging` exporter is now [deprecated](https://github.com/open-telemetry/opentelemetry-collector/pull/11037), users should update the config to the `debug` exporter instead
- The `logging` exporter is now [deprecated](https://github.com/open-telemetry/opentelemetry-collector/pull/11037), users should update the config to the `debug` exporter instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the reference link to debug exporter's README.


#### Changed

- Harbor `2.11.1` to `2.12.1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this include fixing a bug with schema.json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -0,0 +1,133 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems redundant to include as part of every release, wondering if we should consolidate somehow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is across packages, I was thinking we add the new version .md file only if there are significant changes otherwise just rename old to new. What do you think? I can do separate PR for this across packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that sounds reasonable, or we probably don't even need to include version? We can explore restructuring this to point to upstream because that is what we do anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants