-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support httpx/httpcore #248
Comments
Hi @smcoll Thanks for opening this feature request. I'll put this in our backlog and would work on it as soon as possible. We would highly appreciate if you want to contribute towards the I would also recommend you to try and open this request on the OpenTelemetry for Python since it already has a wide array of growing instrumentation support and also active contribution from the open source community. We are also actively working to provide X-Ray support for customers using OpenTelemetry Python. |
Cool - i added issue open-telemetry/opentelemetry-python-contrib#263 |
at first I thought aiohttp was needed, but it's actually available via https://github.com/aws/aws-xray-sdk-python#working-with-aiohttp if you see the client portion. Note however that opentracing support in aiohttp is not complete per aio-libs/aiohttp#3084 |
btw for others that want to enable it globally I'm doing something like this (note untested): def _wrap_clientsession_init(func, instance, args, kwargs):
trace_config = aws_xray_trace_config()
kwargs['trace_configs'] = [trace_config]
return func(*args, **kwargs)
wrapt.wrap_function_wrapper(aiohttp, "ClientSession.__init__", _wrap_clientsession_init) |
i'd be interested in seeing support for
httpx
alongsideaiohttp
,httplib
, andrequests
. The default transport layer forhttpx
ishttpcore
which supports HTTP/2 in addition to HTTP/1.1.These libraries have async support for
asyncio
,trio
, andcurio
.The text was updated successfully, but these errors were encountered: