Add awsQueryCompatible trait support to API #4523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When awsQueryCompatible trait is found, it's made available as an API property. When this property is found, the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson. A test service has been generated for validating assumptions Added unit tests as per the SEP
eddy-aws
changed the title
jasdel
suggested changes
Aug 17, 2022
private/model/api/codegentest/service/awsquerycompatible/awsquerycompatible_test.go
Outdated
Show resolved
Hide resolved
private/model/api/codegentest/service/awsquerycompatible/awsquerycompatible_test.go
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Aug 17, 2022
private/model/api/codegentest/service/awsquerycompatible/awsquerycompatible_test.go
Outdated
Show resolved
Hide resolved
- Add unmodelled exceptoion handling capability by adding new error types - Add unmodelled exceptions to exceptionFromCode mapping - Improve testing by adding integration testts
jasdel
suggested changes
Aug 18, 2022
jasdel
approved these changes
Aug 19, 2022
|
Closing due to the changes to the SEP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When awsQueryCompatible trait is found, it's made available as an API property. When this property is found,
the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from
AWSQuery wire protocol to AWSJson.
A test service has been generated for validating assumptions
Added unit tests as per the SEP
For changes to files under the
/model/folder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.