feat(type-safe-api): handlers default to python 3.13 and node 22 #900
Conversation
|
View your CI Pipeline Execution ↗ for commit 9761dda.
☁️ Nx Cloud last updated this comment at |
In order to default to the most secure configuration, handler functions now default to the latest supported AWS Lambda runtimes for Python and Node. BREAKING CHANGE: API handlers that don't specify the runtime version need to be validated with Python 3.13 or Node 22.
Updating test snapshots in a separate commit for review readability.
jstrunk
force-pushed
the
feat/defaultruntimes
branch
from
3673df2 to
98377ff
Compare
|
@cogwirrel Any thoughts on this PR? |
Hey! I like the idea of using the latest by default :) I think it should be all good - have you tested that the lambda handlers work with these versions? (iirc pydantic can be a bit funky with python versions as it has a native component) Also I think you might need to update the documentation to ensure users use python 3.13 as I think projen creates a virtualenv using whatever |
|
This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
|
My testing on a real project are pending #905 . |
|
@cogwirrel I have validated Lambda handlers with Python 3.13 and Node 22 in https://github.com/aws-samples/aws-smart-product-onboarding. |
Fantastic, thank you! |
|
@cogwirrel This build failure doesn't seem related to my change. @nrwl/tao is now deprecated, but I think that requires a new version of NX. Maybe this was transitory and will work if the build is attempted again? |
Yep looks like NX half-released the latest v19 and then deprecated it! Fixed here: #906 |
In order to default to the most secure configuration, handler functions now default to the latest
supported AWS Lambda runtimes for Python and Node.
BREAKING CHANGE: API handlers that don't specify the runtime version need to be validated with
Python 3.13 or Node 22.
Depends on #899