[BUG] (cdk-graph-plugin-threat-composer) Generated architecture image too large for threat composer #721
Labels
Comments
|
Is this a bug in PDK or Threat composer? |
|
Kind of both, I've raised one for threat composer here: awslabs/threat-composer#100 I think we should keep this open so we remember to switch to svg output. |
cogwirrel
added a commit
that referenced
this issue
Mar 19, 2024
…id size limit Embed the svg diagram into the generated threat model instead of the png as it is much smaller, and does not exceed threat composer's 1MB image size limit. Fixes #721
agdimech
added a commit
that referenced
this issue
Mar 19, 2024
…id size limit (#728) Embed the svg diagram into the generated threat model instead of the png as it is much smaller, and does not exceed threat composer's 1MB image size limit. Fixes #721 Co-authored-by: Adrian Dimech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
After adding some infrastructure, the embedded png image can be too large to import to threat composer.
Expected Behavior
Able to import a generated threat model into threat composer.
Current Behavior
Reproduction Steps
Add a few components, import the generated
threat-model.tc.jsonfile into threat composer.Possible Solution
Add support for svg images in threat composer as they will likely be much smaller. Consider also increasing the size limit.
Additional Information/Context
No response
PDK version used
0.23.13
What languages are you seeing this issue on?
Typescript, Java, Python
Environment details (OS name and version, etc.)
OSX
The text was updated successfully, but these errors were encountered: