Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] (type-safe-api) Ability to configure runtime/language versions in one place #672

Closed
1 of 2 tasks
cogwirrel opened this issue Dec 19, 2023 · 0 comments · Fixed by #688
Closed
1 of 2 tasks

[FEATURE] (type-safe-api) Ability to configure runtime/language versions in one place #672

cogwirrel opened this issue Dec 19, 2023 · 0 comments · Fixed by #688
Labels
feature-request New feature or request needs-triage

Comments

@cogwirrel
Copy link
Member

Describe the feature

Related to #671 - we need to ensure the Python version in the poetry env is the same as the one used as the lambda runtime.

It would be great to be able to configure this, eg specify Python 3.12 in the .projenrc and have the generated function constructs honour this version, as well as the poetry env.

The same should be true for Node (eg esbuild should target the node version used in the lambda runtime), and Java (eg the pom.xml language version should match the version used in the lambda runtime).

Use Case

Customise runtime versions

Proposed Solution

Possibly a configuration option in the .projenrc

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

PDK version used

0.22.43

What languages will this feature affect?

Typescript, Java, Python

Environment details (OS name and version, etc.)

OSX
@cogwirrel cogwirrel added feature-request New feature or request needs-triage labels Dec 19, 2023
cogwirrel added a commit that referenced this issue Jan 23, 2024
@cogwirrel
feat(type-safe-api): support configuring lambda handler runtime versions
bff6c4e 
Users can now specify the runtime version for python, java and typescript (node) lambda handlers. As
well as the lambda runtime version, this configures settings for the project itself to target that
particular runtime, and is therefore configured in the projenrc.

Fixes #672
@cogwirrel cogwirrel mentioned this issue Jan 23, 2024
Merged
cogwirrel added a commit that referenced this issue Jan 23, 2024
@cogwirrel
feat(type-safe-api): support configuring lambda handler runtime versi…
ff156db 
…ons (#688)

Users can now specify the runtime version for python, java and typescript (node) lambda handlers. As
well as the lambda runtime version, this configures settings for the project itself to target that
particular runtime, and is therefore configured in the projenrc.

Fixes #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(type-safe-api): support configuring lambda handler runtime versions aws/aws-pdk
1 participant
@cogwirrel