Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the version of Amazon.CDK.Lib that is referenced by the recipe CDK projects #818

Merged
merged 3 commits into from
Mar 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Configure permissions to allow CloudFront to write to the access…
… log S3 bucket when creating a new bucket for the Blazor WebAssembly App recipe
ashovlin committed Mar 20, 2024

Verified

This commit was signed with the committer’s verified signature.
radoering Randy Döring
commit db28b6477e0336582d479dd955f34c85904e167c
Original file line number Diff line number Diff line change
@@ -132,6 +132,7 @@ private void ConfigureCloudFrontDistribution(Configuration settings)
var loggingBucket = new Bucket(this, nameof(AccessLoggingBucket), InvokeCustomizeCDKPropsEvent(nameof(AccessLoggingBucket), this, new BucketProps
{
RemovalPolicy = RemovalPolicy.RETAIN,
AccessControl = BucketAccessControl.LOG_DELIVERY_WRITE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the CDK version, noticed that this is failing as well due to a change in S3 behavior last year. See aws/aws-cdk#27571 for more info.

}));

distributionProps.LogBucket = loggingBucket;
Loading