-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): added support for bootstrapSelfManagedAddons
#33597
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33597 +/- ##
=======================================
Coverage 82.20% 82.21%
=======================================
Files 119 119
Lines 6862 6876 +14
Branches 1158 1162 +4
=======================================
+ Hits 5641 5653 +12
- Misses 1118 1120 +2
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30792
Reason for this change
The feature enables support to create clusters without the default networking add-ons
Description of changes
Describe any new or updated permissions being added
Added the prop bootstrapSelfManagedAddons to the cluster and incremented the eks client version. Also validated that existing if bootstrapSelfManagedAddons is undefined to true or vice versa does not replace the cluster as the default is
true
.Description of how you validated changes
Validated the changes against an existing cluster and made sure it is not replaced unless the change is from true to false or vice versa.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license