Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): added support for bootstrapSelfManagedAddons #33597

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mrlikl
Copy link
Contributor

@mrlikl mrlikl commented Feb 26, 2025

Issue # (if applicable)

Closes #30792

Reason for this change

The feature enables support to create clusters without the default networking add-ons

Description of changes

Describe any new or updated permissions being added

Added the prop bootstrapSelfManagedAddons to the cluster and incremented the eks client version. Also validated that existing if bootstrapSelfManagedAddons is undefined to true or vice versa does not replace the cluster as the default is true.

Description of how you validated changes

Validated the changes against an existing cluster and made sure it is not replaced unless the change is from true to false or vice versa.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrlikl mrlikl marked this pull request as draft February 26, 2025 19:58
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Feb 26, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 26, 2025 19:58
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Feb 26, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (5eeee75) to head (1a6916f).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33597   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         119      119           
  Lines        6862     6876   +14     
  Branches     1158     1162    +4     
=======================================
+ Hits         5641     5653   +12     
- Misses       1118     1120    +2     
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (+<0.01%) ⬆️

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 27, 2025 07:20

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrlikl mrlikl marked this pull request as ready for review February 27, 2025 13:03
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1a6916f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Support for BootstrapSelfManagedAddons while creating the cluster
2 participants