-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apprunner): add ObservabilityConfiguration for AppRunner Service #30359
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a4e11b4
add ObservabilityConfiguration for AppRunner Service
mazyu36 e73b10d
feat: add fromArn method
mazyu36 0027a86
Merge branch 'main' into apprunner-observability-22985
mazyu36 78629f1
Merge branch 'main' into apprunner-observability-22985
mazyu36 10277c4
Update packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts
mazyu36 4af4868
Update packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts
mazyu36 c532781
Update packages/@aws-cdk/aws-apprunner-alpha/README.md
mazyu36 8a7f2f7
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 b0cc774
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 71da222
Update packages/@aws-cdk/aws-apprunner-alpha/test/service.test.ts
mazyu36 b93cd9b
fix: incorporate review comments
mazyu36 d525912
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 4812423
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 d667bb4
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 f6e9e2c
Update packages/@aws-cdk/aws-apprunner-alpha/test/service.test.ts
mazyu36 2481648
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 8ac81d3
fix: incorporate review comments
mazyu36 0594cd0
Update packages/@aws-cdk/aws-apprunner-alpha/lib/observability-config…
mazyu36 6d5a86c
Merge branch 'main' into apprunner-observability-22985
mazyu36 1e5f12e
fix: update from method
mazyu36 db48ffe
add tag test
mazyu36 6eaaee0
Merge branch 'main' into apprunner-observability-22985
mergify[bot] 8459f87
resolve conflict
mazyu36 4718de2
Merge branch 'main' into apprunner-observability-22985
mazyu36 c850eb3
Merge branch 'main' into apprunner-observability-22985
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// AWS::AppRunner CloudFormation Resources: | ||
export * from './observability-configuration'; | ||
export * from './service'; | ||
export * from './vpc-connector'; | ||
export * from './observability-configuration'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a validation for observabilityConfigurationName and unit tests.