Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): assets can now depend on stacks #25536

Merged
merged 129 commits into from
May 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
ae44fc4
initial project structure
kaizencc Mar 2, 2023
b6fd1eb
skeleton implementation
kaizencc Mar 2, 2023
6b59b29
get everything to compile
kaizencc Mar 2, 2023
4ca12fe
delete extraneous files
kaizencc Mar 2, 2023
6ee9d78
more untested progress
kaizencc Mar 4, 2023
696d275
add bedrock for testing
kaizencc Mar 4, 2023
d73f27f
implement staging stack in synth
kaizencc Mar 6, 2023
5153ef5
get basic test to succeed
kaizencc Mar 6, 2023
c3628f4
remove extra lines
kaizencc Mar 7, 2023
a3a4c79
forgot to commit
kaizencc Mar 7, 2023
fc52f21
tests for docker asset and file asset
kaizencc Mar 7, 2023
e292810
add in iam roles
kaizencc Mar 8, 2023
3fd54e1
handle assets
kaizencc Mar 8, 2023
12283bd
assets
kaizencc Mar 8, 2023
8681478
small things
kaizencc Mar 8, 2023
ae2781e
2 tests
kaizencc Mar 8, 2023
143df73
add no tokens
kaizencc Mar 8, 2023
d5a50c3
better error messaging
kaizencc Mar 9, 2023
d088ec8
more work
kaizencc Mar 9, 2023
f3673ca
bootstrap role
kaizencc Mar 10, 2023
4b6944b
basic functionality for file assets
kaizencc Mar 15, 2023
70d6d85
better role
kaizencc Mar 15, 2023
3a96ee0
major clean up
kaizencc Mar 16, 2023
b7e0b6a
use bootstrapless synth
kaizencc Mar 16, 2023
b678df5
Merge branch 'main' into conroy/bootstrap
kaizencc Mar 16, 2023
b3eb0a6
expose appId to user
kaizencc Mar 17, 2023
26985ab
rename folder
kaizencc Mar 17, 2023
f1462dd
rename
kaizencc Mar 17, 2023
5dc7a5f
adr
kaizencc Mar 17, 2023
42b8566
readme start
kaizencc Mar 17, 2023
6e57c29
minor changes
kaizencc Mar 20, 2023
2a5c44e
move appId to the app props
kaizencc Mar 20, 2023
fb50b3d
new tests
kaizencc Mar 20, 2023
5483fe2
IStagingStack
kaizencc Mar 20, 2023
543bafe
lifecylce rules and kms key
kaizencc Mar 20, 2023
4085c79
wip of kms key debacle
kaizencc Mar 22, 2023
f4074b6
kms key works
kaizencc Mar 22, 2023
c3d1fff
update readme for new api
kaizencc Mar 22, 2023
827fea1
remove app chnages
kaizencc Mar 22, 2023
b77eaf9
remove app chnages
kaizencc Mar 22, 2023
b8cd873
appid
kaizencc Mar 22, 2023
7d115ca
massive changes to api but tests succeed
kaizencc Mar 23, 2023
5754712
rename folder
kaizencc Mar 23, 2023
46da1cc
add roles stuff without testing yet
kaizencc Mar 23, 2023
20c8032
minor cleanups
kaizencc Mar 24, 2023
3b55d82
error when mixing agnostic/non-agnostic stacks in an app
kaizencc Mar 24, 2023
e9b1030
additional bootstrap role test
kaizencc Mar 24, 2023
b168308
rename to app-staging-synthesizer
kaizencc Mar 24, 2023
3eee189
add documentation everywhere and comment out docker code
kaizencc Mar 24, 2023
4fbae1b
more docs
kaizencc Mar 24, 2023
d3ec8a7
couple more tests
kaizencc Mar 24, 2023
d8e3af3
Merge branch 'main' of https://github.com/aws/aws-cdk into conroy/boo…
kaizencc Apr 4, 2023
bdd8a71
get package to work under new repo restructure
kaizencc Apr 4, 2023
806221e
rename to -alpha
kaizencc Apr 5, 2023
6fcc13d
update package.json
kaizencc Apr 5, 2023
6f6c9d3
Merge branch 'main' into conroy/bootstrap
kaizencc Apr 5, 2023
477f81f
rename
kaizencc Apr 5, 2023
a9e4b5a
integ test works
kaizencc Apr 5, 2023
9269b9c
resolve qualifier in the synth
kaizencc Apr 6, 2023
9728364
90% of lifecycle rules for ephemeral assets
kaizencc Apr 6, 2023
0487959
grant access to s3 bucket to deploy role
kaizencc Apr 7, 2023
7460def
introduce new translation functions in core
kaizencc Apr 7, 2023
08cd887
use new translation functions
kaizencc Apr 7, 2023
794cc68
revamp bootstrap roles api
kaizencc Apr 10, 2023
2104e68
move tests around
kaizencc Apr 10, 2023
8a12d60
more test stuff
kaizencc Apr 10, 2023
745770f
finish s3 lifecycle rule tests
kaizencc Apr 10, 2023
5db8d0a
expose bucket prefix api
kaizencc Apr 10, 2023
2f5f962
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr Apr 11, 2023
065e8d4
Fix build
rix0rrr Apr 11, 2023
3d83f4a
env-agnostic test
kaizencc Apr 11, 2023
b7bed7e
Move some code around
rix0rrr Apr 12, 2023
7e5ec32
Merge branch 'conroy/bootstrap' of github.com:aws/aws-cdk into conroy…
rix0rrr Apr 12, 2023
9d080b5
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr Apr 12, 2023
6f33075
minor changes
kaizencc Apr 12, 2023
e4b15f4
Reorganize responsibilities between:
rix0rrr Apr 13, 2023
1d836aa
Merge branch 'conroy/bootstrap' of github.com:aws/aws-cdk into conroy…
rix0rrr Apr 13, 2023
cd39826
Fix build issues
rix0rrr Apr 13, 2023
d79aba3
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr Apr 13, 2023
b642943
awslint fixes
rix0rrr Apr 13, 2023
2a84b5c
Fix unit tests
rix0rrr Apr 13, 2023
2331ef4
asset dependencies
kaizencc Apr 13, 2023
4aee77b
Merge branch 'conroy/bootstrap' of https://github.com/aws/aws-cdk int…
kaizencc Apr 13, 2023
b20cb04
wip of workgraph code. does not work yet, many errors
kaizencc Apr 14, 2023
ff3de55
Merge branch 'main' into conroy/bootstrap
kaizencc Apr 17, 2023
ffdfa8f
bigtime changes to the cli that are wip
kaizencc Apr 19, 2023
a0570d2
get to no compilation errors
kaizencc Apr 20, 2023
06dd548
all tests in deploy.test succeed
kaizencc Apr 21, 2023
16e46df
major overhaul of test to make it make sense
kaizencc Apr 21, 2023
c3268f7
fix rest of the tests in display.ts
kaizencc Apr 24, 2023
a0851eb
remove etraneous files
kaizencc Apr 24, 2023
466e3cd
callback interface for deployArtifacts
kaizencc Apr 24, 2023
13795c9
worknode is now an abstract class
kaizencc Apr 24, 2023
9c0183a
Merge branch 'main' into conroy/bootstrap
kaizencc Apr 26, 2023
01fc565
add disable prebuild to workgraph
kaizencc Apr 27, 2023
075ed8b
typo
kaizencc Apr 27, 2023
c4af16e
nested assemblies
kaizencc Apr 27, 2023
925812e
wip of app-staging stuff
kaizencc May 3, 2023
62712b8
Pass deployRoleArn
rix0rrr May 3, 2023
0c5e48c
integ tests r good
kaizencc May 3, 2023
a7b61a4
add assetname to ecr-assets
kaizencc May 3, 2023
5290ad3
update integ test
kaizencc May 4, 2023
0e25c13
more test updates
kaizencc May 4, 2023
53287e0
Merge branch 'main' into conroy/bootstrap
kaizencc May 5, 2023
21564fe
update sto ecr asets
kaizencc May 5, 2023
0cc17e5
Merge branch 'conroy/bootstrap' of https://github.com/aws/aws-cdk int…
kaizencc May 5, 2023
91389b0
grantread
kaizencc May 5, 2023
2d9719e
more unit tests
kaizencc May 8, 2023
475ebe9
unit test for gnostic stuff
kaizencc May 8, 2023
f0867bb
error when staging resource stack too large
kaizencc May 8, 2023
06e3183
Change the work graph to put individual assets into it and publish th…
rix0rrr May 9, 2023
e814bfd
Remove files that should be part of a different PR
rix0rrr May 11, 2023
3d9d0bb
More refactoring work
rix0rrr May 11, 2023
6bd21cf
Remove more files that should be in a different PR
rix0rrr May 11, 2023
0cd79b8
Fix tests
rix0rrr May 11, 2023
1e8e2c5
Merge remote-tracking branch 'origin/main' into huijbers/refactor-assets
rix0rrr May 11, 2023
743a679
Coverage a bit low
rix0rrr May 12, 2023
f91556b
Fix up some review comments
rix0rrr May 12, 2023
61297f8
Remove duplicate status event
rix0rrr May 12, 2023
762933c
Rename 'cloudformation-deployments' -> 'deployments', add priorities …
rix0rrr May 12, 2023
57886f6
Lower coverage
rix0rrr May 12, 2023
8971ad7
Made change in wrong file
rix0rrr May 12, 2023
c348f99
Fix improts & add dependency
rix0rrr May 12, 2023
0a49f81
Add a test for node removal
rix0rrr May 12, 2023
2285a97
3p licenses for some reason
rix0rrr May 12, 2023
46d5d80
Move property, otherwise we have a breaking API change
rix0rrr May 12, 2023
c128525
Review comments
rix0rrr May 16, 2023
5fc82da
Incorrect test translation
rix0rrr May 16, 2023
0fc6754
Merge branch 'main' into huijbers/refactor-assets
mergify[bot] May 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assets
kaizencc committed Mar 8, 2023
commit 12283bdc32a23b80a25539e2c8593ff4df9f14d9
7 changes: 7 additions & 0 deletions packages/@aws-cdk/core/lib/assets.ts
Original file line number Diff line number Diff line change
@@ -242,6 +242,13 @@ export interface DockerImageAssetSource {
*/
readonly dockerOutputs?: string[];

/**
* Unique identifier of the docker image asset and its potential revisions.
* Required if using Bootstrap v3.
*
* @default - no unique id
*/
readonly uniqueId?: string;
}

/**