-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new synthesizer separates assets out per CDK application #24430
Merged
+5,403
−61
Merged
Changes from 1 commit
Commits
Show all changes
137 commits
Select commit
Hold shift + click to select a range
ae44fc4
initial project structure
kaizencc b6fd1eb
skeleton implementation
kaizencc 6b59b29
get everything to compile
kaizencc 4ca12fe
delete extraneous files
kaizencc 6ee9d78
more untested progress
kaizencc 696d275
add bedrock for testing
kaizencc d73f27f
implement staging stack in synth
kaizencc 5153ef5
get basic test to succeed
kaizencc c3628f4
remove extra lines
kaizencc a3a4c79
forgot to commit
kaizencc fc52f21
tests for docker asset and file asset
kaizencc e292810
add in iam roles
kaizencc 3fd54e1
handle assets
kaizencc 12283bd
assets
kaizencc 8681478
small things
kaizencc ae2781e
2 tests
kaizencc 143df73
add no tokens
kaizencc d5a50c3
better error messaging
kaizencc d088ec8
more work
kaizencc f3673ca
bootstrap role
kaizencc 4b6944b
basic functionality for file assets
kaizencc 70d6d85
better role
kaizencc 3a96ee0
major clean up
kaizencc b7e0b6a
use bootstrapless synth
kaizencc b678df5
Merge branch 'main' into conroy/bootstrap
kaizencc b3eb0a6
expose appId to user
kaizencc 26985ab
rename folder
kaizencc f1462dd
rename
kaizencc 5dc7a5f
adr
kaizencc 42b8566
readme start
kaizencc 6e57c29
minor changes
kaizencc 2a5c44e
move appId to the app props
kaizencc fb50b3d
new tests
kaizencc 5483fe2
IStagingStack
kaizencc 543bafe
lifecylce rules and kms key
kaizencc 4085c79
wip of kms key debacle
kaizencc f4074b6
kms key works
kaizencc c3d1fff
update readme for new api
kaizencc 827fea1
remove app chnages
kaizencc b77eaf9
remove app chnages
kaizencc b8cd873
appid
kaizencc 7d115ca
massive changes to api but tests succeed
kaizencc 5754712
rename folder
kaizencc 46da1cc
add roles stuff without testing yet
kaizencc 20c8032
minor cleanups
kaizencc 3b55d82
error when mixing agnostic/non-agnostic stacks in an app
kaizencc e9b1030
additional bootstrap role test
kaizencc b168308
rename to app-staging-synthesizer
kaizencc 3eee189
add documentation everywhere and comment out docker code
kaizencc 4fbae1b
more docs
kaizencc d3ec8a7
couple more tests
kaizencc d8e3af3
Merge branch 'main' of https://github.com/aws/aws-cdk into conroy/boo…
kaizencc bdd8a71
get package to work under new repo restructure
kaizencc 806221e
rename to -alpha
kaizencc 6fcc13d
update package.json
kaizencc 6f6c9d3
Merge branch 'main' into conroy/bootstrap
kaizencc 477f81f
rename
kaizencc a9e4b5a
integ test works
kaizencc 9269b9c
resolve qualifier in the synth
kaizencc 9728364
90% of lifecycle rules for ephemeral assets
kaizencc 0487959
grant access to s3 bucket to deploy role
kaizencc 7460def
introduce new translation functions in core
kaizencc 08cd887
use new translation functions
kaizencc 794cc68
revamp bootstrap roles api
kaizencc 2104e68
move tests around
kaizencc 8a12d60
more test stuff
kaizencc 745770f
finish s3 lifecycle rule tests
kaizencc 5db8d0a
expose bucket prefix api
kaizencc 2f5f962
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr 065e8d4
Fix build
rix0rrr 3d83f4a
env-agnostic test
kaizencc b7bed7e
Move some code around
rix0rrr 7e5ec32
Merge branch 'conroy/bootstrap' of github.com:aws/aws-cdk into conroy…
rix0rrr 9d080b5
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr 6f33075
minor changes
kaizencc e4b15f4
Reorganize responsibilities between:
rix0rrr 1d836aa
Merge branch 'conroy/bootstrap' of github.com:aws/aws-cdk into conroy…
rix0rrr cd39826
Fix build issues
rix0rrr d79aba3
Merge remote-tracking branch 'origin/main' into conroy/bootstrap
rix0rrr b642943
awslint fixes
rix0rrr 2a84b5c
Fix unit tests
rix0rrr 2331ef4
asset dependencies
kaizencc 4aee77b
Merge branch 'conroy/bootstrap' of https://github.com/aws/aws-cdk int…
kaizencc b20cb04
wip of workgraph code. does not work yet, many errors
kaizencc ff3de55
Merge branch 'main' into conroy/bootstrap
kaizencc ffdfa8f
bigtime changes to the cli that are wip
kaizencc a0570d2
get to no compilation errors
kaizencc 06dd548
all tests in deploy.test succeed
kaizencc 16e46df
major overhaul of test to make it make sense
kaizencc c3268f7
fix rest of the tests in display.ts
kaizencc a0851eb
remove etraneous files
kaizencc 466e3cd
callback interface for deployArtifacts
kaizencc 13795c9
worknode is now an abstract class
kaizencc 9c0183a
Merge branch 'main' into conroy/bootstrap
kaizencc 01fc565
add disable prebuild to workgraph
kaizencc 075ed8b
typo
kaizencc c4af16e
nested assemblies
kaizencc 925812e
wip of app-staging stuff
kaizencc 62712b8
Pass deployRoleArn
rix0rrr 0c5e48c
integ tests r good
kaizencc a7b61a4
add assetname to ecr-assets
kaizencc 5290ad3
update integ test
kaizencc 0e25c13
more test updates
kaizencc 53287e0
Merge branch 'main' into conroy/bootstrap
kaizencc 21564fe
update sto ecr asets
kaizencc 0cc17e5
Merge branch 'conroy/bootstrap' of https://github.com/aws/aws-cdk int…
kaizencc 91389b0
grantread
kaizencc 2d9719e
more unit tests
kaizencc 475ebe9
unit test for gnostic stuff
kaizencc f0867bb
error when staging resource stack too large
kaizencc c6fb952
add ecr lifecycle rules
kaizencc 95a9362
lint
kaizencc f679b2c
update testing suite and minor bugs
kaizencc 39d95e7
readme updates, wip
kaizencc 505227f
rename IStagingStack to IStagingResources
kaizencc 01baa7b
more readme
kaizencc 28e3324
wip integ test
kaizencc d38dc36
wip integ test
kaizencc f9443f2
Undo some changes that are now on the ot her branch
rix0rrr 5162dca
Remove some more files
rix0rrr 34e0cf6
Apply suggestions from code review
kaizencc 5a910bb
pr feedback wip
kaizencc 1437915
pr feedback, rosetta passes, tests pass
kaizencc ca3cbc6
Merge branch 'main' into conroy/bootstrap
kaizencc 2ea6d0a
rename app-staging-synthesizer into app-staging-synthesizer-alpha
kaizencc d1c873b
mark template assets as ephemeral
kaizencc 1b71b51
Merge branch 'conroy/bootstrap' of https://github.com/aws/aws-cdk int…
kaizencc c91fc26
fix merge
kaizencc 2c60623
fix tests
kaizencc 37074c4
rename ephemeral into deployTime
kaizencc e0a9089
update readme content
kaizencc af5856b
final updates
kaizencc 800bd89
Merge branch 'main' into conroy/bootstrap
kaizencc b1210b3
minor renames
kaizencc 48270f4
catch errors in isPublished so removePublishedAsets cannot fail
kaizencc 93dad51
silence warning messages when calling is__Published
kaizencc 550f50b
Merge branch 'main' into conroy/bootstrap
kaizencc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
expose bucket prefix api
commit 5db8d0a516bdc793644c77c725e17103abe2833b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is always true for all Lambda assets, why ask the user to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I haven't yet updated lambda's side to always tag their assets as ephemeral. That belongs in a different PR imo. I suppose I'll do that now and update the readme accordingly