feat(aws-ec2): userdata cfn-signal signal resource which is different than the attached resource #16264
+90
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e attached resource
|
|
Closed
2 tasks
|
@njlynch, I've fixed the merging conflict with master. |
njlynch
reviewed
Sep 28, 2021
njlynch
previously approved these changes
Sep 28, 2021
njlynch
added
the
pr-linter/exempt-readme
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
njlynch
approved these changes
Sep 29, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
… than the attached resource (aws#16264) When using `cfn-init` in EC2 UserData with a LaunchTemplate and an AutoScalingGroup the attached resource (used with `cfn-init`) is the LaunchTemplate but the signal (`cfn-signal`) should call the AutoScalingGroup. `CloudFormationInit::attach` method supports only a single resource for both init and signal - blocking the usage of LaunchTemplate and AutoScalingGroup scenario. The commit avoids a breaking change in the function signature, by adding an optional `signalResource` to the `AttachInitOptions` parameters argument ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
cfn-initin EC2 UserData with a LaunchTemplate and an AutoScalingGroup the attached resource (used withcfn-init) is the LaunchTemplate but the signal (cfn-signal) should call the AutoScalingGroup.CloudFormationInit::attachmethod supports only a single resource for both init and signal - blocking the usage of LaunchTemplate and AutoScalingGroup scenario.The commit avoids a breaking change in the function signature, by adding an optional
signalResourceto theAttachInitOptionsparameters argumentBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license