Add workflow to automate versioning #962
Merged
+187
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
commented
Mar 26, 2025
| exempt-issue-labels: 'bug,dnc' | ||
| exempt-pr-labels: 'bug,dnc' | ||
| exempt-issue-labels: 'bug,dnc,new release' | ||
| exempt-pr-labels: 'bug,dnc,new release' |
There was a problem hiding this comment.
To avoid deleting a branch created by update package version workflow
| @@ -30,7 +30,8 @@ const useRemoteVersion = () => { | |||
| if (!packageJson) { | |||
| return false; | |||
| } else { | |||
| return version !== packageJson.data.version; | |||
| // Compare only major versions | |||
| return version.split('.')[0] !== packageJson.data.version.split('.')[0]; | |||
There was a problem hiding this comment.
Since patch and minor version updates will become more frequent, update notifications will be changed to major versions only
maekawataiki
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容の説明
チェック項目
npm run lintを実行したnpm run cdk:testを実行しスナップショット差分がある場合はnpm run cdk:test:update-snapshotを実行してスナップショットを更新した関連する Issue
N/A