Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zlib url for debian-ubuntu image #143

Closed
wants to merge 1 commit into from
Closed

fix zlib url for debian-ubuntu image #143

wants to merge 1 commit into from

Conversation

matyasbach
Copy link

Motivation

  • Unable to follow Debian image build step because of zlib url returning 404.

Modifications

Change summary

  • Changed zlib url to github release which is probably more stable than zlib.net one + updated to newest version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

JoaoPedroLucatto
JoaoPedroLucatto suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@JoaoPedroLucatto JoaoPedroLucatto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be breaking compatibility by changing the lib version, what do you think about using the same version.

@matyasbach matyasbach changed the title fix zlib url and upgrade version for debian-ubuntu image fix zlib url for debian-ubuntu image Feb 13, 2024
@matyasbach
Copy link
Author

Closing, as this change was part of merged #147

@matyasbach matyasbach closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoPedroLucatto JoaoPedroLucatto JoaoPedroLucatto requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matyasbach @JoaoPedroLucatto