-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Setup typedoc to build references.json and configure release workflow to update docs site #14255
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow looks good to me. But have some questions with the typedoc config change.
@@ -2,15 +2,34 @@ | |||
"name": "Amplify JS API Documentation", | |||
"entryPointStrategy": "packages", | |||
"entryPoints": [ | |||
"packages/adapter-nextjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated.
"packages/aws-amplify/storage", | ||
"packages/aws-amplify/storage/server", | ||
"packages/aws-amplify/utils", | ||
"packages/core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this line will cause our API reference page: https://aws-amplify.github.io/amplify-js/api/ to show the internal package @aws-amplify/core
.
I'm thinking of using a separate typedoc config to generate reference.json
that includes every thing doc side needs.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.