Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup typedoc to build references.json and configure release workflow to update docs site #14255

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stocaaro
Copy link
Member

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro changed the title chore: Configure typedoc chore: Setup typedoc to build references.json and configure release workflow to update docs site Mar 4, 2025
Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow looks good to me. But have some questions with the typedoc config change.

@@ -2,15 +2,34 @@
"name": "Amplify JS API Documentation",
"entryPointStrategy": "packages",
"entryPoints": [
"packages/adapter-nextjs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated.

"packages/aws-amplify/storage",
"packages/aws-amplify/storage/server",
"packages/aws-amplify/utils",
"packages/core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this line will cause our API reference page: https://aws-amplify.github.io/amplify-js/api/ to show the internal package @aws-amplify/core.

I'm thinking of using a separate typedoc config to generate reference.json that includes every thing doc side needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants