Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL 8 Reserved Word "Groups" #23

Closed
wants to merge 4 commits into from
Closed

Conversation

amsclark
Copy link
Contributor

GROUPS is a new reserved word in MySQL 8:
https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-in-current-series

This causes problems for OCM because OCM has a table called groups. Queries that reference this table therefore cause a syntax error if MySQL 8 is used in production. The issue can be resolved by wrapping the groups table name in backtics.

Merry Christmas,

--AC

@aworley
Copy link
Owner

aworley commented Jan 17, 2020

Hi Alex! This code looks great and I'm sure you've tested it, but it is also a really big change and I'd feel the need to also do my own testing before merging it. I do not have the bandwidth at this point to do the testing, and I don't have anyone using MySQL 8.0, so I will respectfully decline to accept the pull request, but I'm sure you can incorporate this into your own projects.

@aworley aworley closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants