New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction pool error handling and logging in Basic Authorship #734

Open

vipocenka wants to merge 1 commit into availproject:main from vipocenka:fix/fix

vipocenka commented Mar 7, 2025

This PR improves error handling and logging in basic_authorship.rs by:

Adding a specific error log (NODE_CRITICAL_ERROR_005) when there is a failure retrieving transactions from the pool.
Ensuring the transaction pool continues processing in case of an error instead of panicking.
Fixing a missing closing bracket in the block proposal log message.

Testing Performed

Ensured the code compiles without errors using cargo build.
Ran cargo test to verify existing functionality remains intact.
Verified correct logging behavior for transaction pool errors.

Checklist

Performed a self-review of my code.
Ran cargo test successfully.
Formatted the code using cargo fmt.
Ensured no new warnings appear with cargo clippy.
Verified that the block proposal log message is correctly formatted.


          Update basic_authorship.rs

a773130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet