Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty commitments for blocks without any DA extrinsics #519

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

ToufeeqP
Copy link
Contributor

@ToufeeqP ToufeeqP commented Apr 3, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

Description

The commitments will be empty with grid dimension [0,0] for blocks without any DA transactions. This is also the case if for any reason commitment generation fails. In both scenarios, kate query_rows and query_proof RPCs return an error.

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Leouarz
Copy link
Contributor

Leouarz commented Apr 3, 2024

you can merge, the failing benchmarking needs some update, i removed it from the main branch temporarily

@ToufeeqP ToufeeqP merged commit ee0463d into main Apr 3, 2024
18 of 19 checks passed
@ToufeeqP ToufeeqP deleted the toufeeq/empty-commitments branch April 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants