Fix query_proof RPC #514
Merged
Fix query_proof RPC #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterentic
approved these changes
Apr 2, 2024
aterentic-ethernal
requested review from
aterentic
and removed request for
aterentic
aterentic-ethernal
approved these changes
Apr 2, 2024
fmiguelgarcia
approved these changes
Apr 2, 2024
| let mut content = [0u8; 80]; | ||
| content.copy_from_slice(&actual_proof); | ||
| let commitment: [u8; 48] = commitment[48..96].try_into().unwrap(); | ||
| let dcell = kate_recovery::data::Cell { |
There was a problem hiding this comment.
It looks like we can refactor this Cell because we are encoding the scalar to raw bytes some lines above, and then it is decoded inside verify function.
Maybe it could be a new PR after release.
In general, we should avoid any Vec<u8> from encoding/serializing in favor of an specific type like GDataProof.
att. @ToufeeqP @jakubcech
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
Description
Kate query_proof RPC was not extending the columns, As a result, we were not able to fetch the proof for extended cells
Checklist
cargo test.cargo fmt.cargo build --releaseandcargo build --release --features runtime-benchmarks.cargo clippy.