SDK-5963 Swift 6 support #961
Closed
+491
−360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
May 29, 2025
| @@ -51,15 +51,15 @@ public struct WebAuthentication { | |||
| /// - Parameter url: The URL sent by the external user agent that contains the result of the web-based operation. | |||
| /// - Returns: If the URL was expected and properly formatted. | |||
| @discardableResult | |||
| public static func resume(with url: URL) -> Bool { | |||
| return TransactionStore.shared.resume(url) | |||
| public static func resume(with url: URL) async -> Bool { | |||
There was a problem hiding this comment.
This is a breaking change, as it's making async a previously sync function.
Widcket
reviewed
May 29, 2025
| } | ||
|
|
||
| /// Terminates the ongoing web-based operation and reports back that it was cancelled. | ||
| /// You need to call this method within your custom Web Auth provider implementation whenever the operation is | ||
| /// cancelled by the user. | ||
| public static func cancel() { | ||
| TransactionStore.shared.cancel() | ||
| public static func cancel() async { |
There was a problem hiding this comment.
This is a breaking change, as it's making async a previously sync function.
Widcket
reviewed
May 29, 2025
|
|
||
| /// Tears down the external user agent after the web-based operation completed, if needed. | ||
| /// Auth0.swift will call this method after the callback URL was received and processed, or after the user | ||
| /// cancelled the operation, or after any other error occurred. | ||
| /// | ||
| /// - Parameter result: The outcome of the web-based operation, containing either an empty success case or an | ||
| /// error. | ||
| func finish(with result: WebAuthResult<Void>) | ||
| func finish(with result: WebAuthResult<Void>) async |
There was a problem hiding this comment.
This is a breaking change, as it's making async a previously sync function.
Widcket
reviewed
May 29, 2025
|
|
||
| /// Starts the external user agent. | ||
| func start() | ||
| func start() async |
There was a problem hiding this comment.
This is a breaking change, as it's making async a previously sync function.
Widcket
reviewed
May 29, 2025
|
|
||
| /// Thunk that returns a function that creates and returns a ``WebAuthUserAgent`` to perform a web-based operation. | ||
| /// The ``WebAuthUserAgent`` opens the URL in an external user agent and then invokes the callback when done. | ||
| /// | ||
| /// ## See Also | ||
| /// | ||
| /// - [Example](https://github.com/auth0/Auth0.swift/blob/master/Auth0/SafariProvider.swift) | ||
| public typealias WebAuthProvider = (_ url: URL, _ callback: @escaping WebAuthProviderCallback) -> WebAuthUserAgent | ||
| public typealias WebAuthProvider = (_ url: URL, _ callback: @escaping @Sendable WebAuthProviderCallback) async -> WebAuthUserAgent |
There was a problem hiding this comment.
This is a breaking change, as it's making async a previously sync function.
Same for all the other similar changes in this file.
Widcket
reviewed
May 29, 2025
| return UIApplication.shared()?.windows.last(where: \.isKeyWindow) ?? ASPresentationAnchor() | ||
| } | ||
| #endif | ||
|
|
||
| #if os(visionOS) | ||
| func presentationAnchor(for session: ASWebAuthenticationSession) -> ASPresentationAnchor { | ||
| nonisolated func presentationAnchor(for session: ASWebAuthenticationSession) -> ASPresentationAnchor { |
There was a problem hiding this comment.
Should this be nonisolated if this is UI-related code that needs to run on the main thread?
SPPRAGUE
approved these changes
Jun 1, 2025
|
Closed this PR as would create a PR with breaking down the changes not present and strict Swift concurrency is supported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR has major changes in the SDK to enable strict swift concurrency from Swift 6 in the SDK
Conforming protocols and structs to Sendable
Converting classes to Actor wherever required
📎 References
🎯 Testing