This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Tokenize punctuation #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't pull yet, noticed other unscoped brackets: number(2) |
|
@50Wliu This is now ready for review. |
winstliu
reviewed
Jan 19, 2018
spec/grammar-spec.coffee
Outdated
| @@ -167,3 +489,39 @@ describe "SQL grammar", -> | |||
| expect(tokens[3]).toEqual value: ' WITH ', scopes: ['source.sql', 'comment.block.sql'] | |||
| expect(tokens[4]).toEqual value: '*/', scopes: ['source.sql', 'comment.block.sql', 'punctuation.definition.comment.sql'] | |||
| expect(tokens[6]).toEqual value: 'AND', scopes: ['source.sql', 'keyword.other.DML.sql'] | |||
|
|
|||
| it 'tokenizes ()', -> | |||
spec/grammar-spec.coffee
Outdated
| expect(tokens[13]).toEqual value: ' employees', scopes: ['source.sql'] | ||
| expect(tokens[14]).toEqual value: ')', scopes: ['source.sql', 'punctuation.definition.section.bracket.round.end.sql'] | ||
|
|
||
| it 'tokenizes ,', -> |
spec/grammar-spec.coffee
Outdated
| expect(tokens[1]).toEqual value: ',', scopes: ['source.sql', 'punctuation.separator.comma.sql'] | ||
| expect(tokens[2]).toEqual value: ' year', scopes: ['source.sql'] | ||
|
|
||
| it 'tokenizes .', -> |
spec/grammar-spec.coffee
Outdated
| expect(tokens[1]).toEqual value: '.', scopes: ['source.sql', 'punctuation.separator.period.sql'] | ||
| expect(tokens[2]).toEqual value: 'table', scopes: ['source.sql', 'constant.other.table-name.sql'] | ||
|
|
||
| it 'tokenizes ;', -> |
spec/grammar-spec.coffee
Outdated
| @@ -167,3 +489,39 @@ describe "SQL grammar", -> | |||
| expect(tokens[3]).toEqual value: ' WITH ', scopes: ['source.sql', 'comment.block.sql'] | |||
| expect(tokens[4]).toEqual value: '*/', scopes: ['source.sql', 'comment.block.sql', 'punctuation.definition.comment.sql'] | |||
| expect(tokens[6]).toEqual value: 'AND', scopes: ['source.sql', 'keyword.other.DML.sql'] | |||
|
|
|||
| it 'tokenizes ()', -> | |||
There was a problem hiding this comment.
Maybe this could be under a describe 'punctuation', -> block as well.
spec/grammar-spec.coffee
Outdated
| {tokens} = grammar.tokenizeLine('timetz (2)') | ||
| expect(tokens[0]).toEqual value: 'timetz', scopes: ['source.sql', 'storage.type.sql'] | ||
| expect(tokens[2]).toEqual value: '2', scopes: ['source.sql', 'constant.numeric.sql'] | ||
| it 'tokenizes column types', -> |
There was a problem hiding this comment.
This is a rather massive test. We don't have to test for everything, just smoke-test 1-2 from each category (and consider separating into different tests).
This was referenced Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()aspunctuation.definition.section|parameters.bracket.round.begin|end.sql,aspunctuation.separator(.parameters).comma.sql.aspunctuation.separator.period.sql;aspunctuation.terminator.statement.semicolon.sqlncharandbit varying, removedvar char(with a space, couldn't find any documentation on this type)Fixes #68